Python 3.10 for x86 field test - asctim

[imiller]

Here is a little python function which is intended to return how many days before now is the specified VMS time.

Code: Select all

def daysb4(time):

    sts, now = SYS.gettim()
    if (sts & 1) == 1:  # if sucessfully got current time
        sts, time_since = SYS.asctim(time - now, 0)     # convert time to string delta time before now

    if (sts & 1) == 1:
        days_since = 0 + time_since.split("+")	# extract the days
        return days_since
    else:
        return 99999    # indicate error by returning number bigger than any valid delta time
    #endif
#end daysb4

However, what I get is an error that I'm passing a negative number. This should be allowed as VMS binary delta times are negative.

Code: Select all

OverflowError: can't convert negative int to unsigned

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/DATA/IMILLER/PY/fh2.py", line 295, in <module>
    print("rev days b4",daysb4(fi.revdate))
  File "/DATA/IMILLER/PY/fh2.py", line 237, in daysb4
    sts, time_since = SYS.asctim(time - now, 0) # convert time to string delta time before now
SystemError: <built-in function asctim> returned a result with an exception set

[arne_v]

It should work per documentation:

https://wiki.vmssoftware.com/VMS-Specif ... 29-.3Elist

But it does not.

Even though it can be worked around:

Code: Select all

$ type t.py
from vms import sys

dt = -10000000
print(sys.asctim(dt, 0))
$ python t.py
OverflowError: can't convert negative int to unsigned

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/DISK2/ARNE/t.py", line 4, in <module>
    print(sys.asctim(dt, 0))
SystemError: <built-in function asctim> returned a result with an exception set
$ type t2.py
from vms import sys

dt = -10000000
dt = dt & 0x0FFFFFFFFFFFFFFFF
print(sys.asctim(dt, 0))
$ python t2.py
(1, '   0 00:00:01.00')

[craigberry]

Someone probably just used an integer of the wrong sign somewhere. If the source were open, it likely would have been found and fixed today.

[arne_v]

The GitHub repo is there:

https://github.com/vmssoftware/cpython

But it is obviously not uptodate. Last change is 3 years ago.

[sergey_vorfolomeev]

The current branch is 'openvms-3.10.0'.

Modules\vms\sys\_sys.c, line 126

Code: Select all

unsigned long long vms_time = PyLong_AsUnsignedLongLong(args[0]);

That must be just 'long long'.

Code: Select all

long long vms_time = PyLong_AsLongLong(args[0]);

I will fix and test that.

[arne_v]

The current branch is 'openvms-3.10.0'.

Ah.

https://github.com/vmssoftware/cpython/ ... vms-3.10.0

Modules\vms\sys\_sys.c, line 126

Code: Select all

unsigned long long vms_time = PyLong_AsUnsignedLongLong(args[0]);

That must be just 'long long'.

Code: Select all

long long vms_time = PyLong_AsLongLong(args[0]);

I will fix and test that.

https://github.com/vmssoftware/cpython/ ... sys/_sys.c

https://github.com/vmssoftware/cpython/ ... 9259d1d0dc

[imiller]

That's good - I look forward to that fix in the next release.